Open
Conversation
andrestejerina97
force-pushed
the
feature/add-badge-formatters
branch
from
b39cb5e to
e147182
Compare
andrestejerina97
force-pushed
the
feature/add-badge-formatters
branch
2 times, most recently
from
95e3dd9 to
58b90cf
Compare
andrestejerina97
force-pushed
the
feature/add-badge-formatters
branch
from
58b90cf to
bc5ed07
Compare
Contributor
|
@andrestejerina97 |
caseylocker
approved these changes
Feb 11, 2026
caseylocker
left a comment
caseylocker
left a comment
There was a problem hiding this comment.
LGTM Approved.
@martinquiroga-exo I agree that they're virtually identical and it seems wasteful/redundant in a way but it's also a set pattern. It's a good evaluation but not worth rejecting the PR - i.e. your nit vs rejection. Good call. The other PR also was solving for another problem - same entity type with different message formats. This one is the inverse. If we want to address it later we'd need to do so across the board.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/86b8emkur